This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
[pr] Fixes for issue #118 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stephen-palmer
commented
May 9, 2019
stephen-palmer
commented
- Moved whitelist check from _onPut to _onBeginTransaction, Invalidating transactions from IPs that are not whitelisted as soon as they are created
- Have CacheBase process all transactions through the ReliabilityManager when enabled
- Ensure ReliabilityManager does not process invalid transactions
- Moved whitelist check from _onPut to _onBeginTransaction, Invalidating transactions from IPs that are not whitelisted as soon as they are created - Have CacheBase process all transactions through the ReliabilityManager when enabled - Ensure ReliabilityManager does not process invalid transactions
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here - or - cancel by adding [!pr] to the title of the pull request.
… bunch of test runner process args that were interfering with CLI handling.
test/command_processor.js
Outdated
| beforeEach(() => { | ||
| this.cmdProc = new CommandProcessor(new CacheBase()); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| stubs.forEach(s => s.restore()); |
There was a problem hiding this comment.
Have you considered using a sandbox to easily restore all the stubs without having to track them?
There was a problem hiding this comment.
Thanks for the tip - I upgraded Sinon and refactored to use the default sandbox.
…fying the test code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.