Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Conversation

DonGloverUnity
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 13, 2018

Coverage Status

Coverage remained the same at 92.028% when pulling 12c0a7a on DonGloverUnity:doc-updates-don into 1609764 on Unity-Technologies:feature/streams-refactor.

Copy link
Contributor

@stephen-palmer stephen-palmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues found.

README.md Outdated
cachePath | `.cache_ram` | The path to the cache directory. Dirty memory pages are saved to disk periodically in this directory, and loaded at startup.
persistence | true | Enable saving and loading of page files to disk. If `false`, the cache is emptied during restart.
persistenceOptions.autosave | true | When set to `true`, automatically save changed memory pages; set to `false` to disable. If `false`, pages are only saved when the cache server is stopped with the `q` console command or with upon a SIGTERM.
persistenceOptions.autosaveInterval | 10000 | The frequency, in milliseconds, to save page that have changed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page should be plural

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

README.md Outdated

* cache_fs is backwards compatible with v5.x Cache Server directories.
* Supports worker threads using the `--workers` option.
* When you run the cleanup script, the value of the `expireTimeSpan` option is used to determine which file to delete files. If `maxCacheSize` is specified the script checks whether the cache exceeds the value of `maxCacheSize`. If it does, the script deletes files in least-recently-used order until the cache no longer exceed maxCacheSize.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"which file to delete files" doesn't make sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

README.md Outdated
@@ -24,131 +25,183 @@ At present time this open-source repository is maintained separately from the Ca
* [License](#license)

## Server Setup
Download and install the latest LTS version of node from the [Node.JS website](`https://nodejs.org/en/download/`).

Download and install the latest LTS version of Node.js from the [Node.JS website](https://nodejs.org/en/download/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from customer .. confused about the specific version to download. Suggest adding v8.10.0 to this sentence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

README.md Outdated
#### Notes
* Does not support worker threads
pageSize | 100000000 | The page size, in bytes, used to grow the cache.
maxPageCount | 10 | The maximum number of pages to allocate in the cache. The combination of `pageSize` and `maxPageCount` limits the overall memory footprint of the cache. When this threshold is reached, memory recovered using a Least Recently Used (LRU) algorithm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory is recovered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@stephen-palmer stephen-palmer merged commit 22eed8f into Unity-Technologies:feature/streams-refactor Mar 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants