Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement "Editor window to quickly open scenes" task #267 #281

Closed
wants to merge 1 commit into from

Conversation

DSivtsov
Copy link

@DSivtsov DSivtsov commented Dec 25, 2020

forum thread linked to this PR

this PR update & improve early merged PR

this PR bring to the project:

  • make more optimized Editor code (less calls in OnGUI())
  • give additional possibilities to work with Tools for quickly open scenes
    How did you implement them?

Minor changes:

  • separated code of SO "SceneAccessHolderSO" (SceneAccessHolderSO.cs) on:
    -- ReadOnlyPropertyDrawer.cs (It must be in Editor folder - "// The property drawer class should be placed in an editor script, inside a folder called Editor." from Unity Doc)
    -- SceneAccessHolderSOReadOnlyAttribute.cs (It must be not in Editor folder, now in folder with corresponding SO)
    -- now "SceneAccessHolderSO.cs" contain only clean SO.

Major changes:

  • SceneAccessTool.cs
    -- Not demand initial creation of SceneAccessHolderSO, if it absent will create automatically
    -- Fully sync the window "SceneAccessTool" and SceneAccessHolderSO, The user can simultaneously change the SceneListing values and window display parameters directly in the window itself or in the inspector (by change SO).
  • added SceneAccessSOEditor : Editor, which update window if SO changed.
  • window display parameters save to SO and will restored, if window was closed
  • optimized OnGUI () to reduce the number of method calls
  • corrected work with ReorderableList (ToggleEditMode()/OnGui()/OnEnable())
    IMAGE ALT TEXT

@ciro-unity ciro-unity added the tool A PR that contains an Editor tool or custom Inspectors label Jan 7, 2021
@amel-unity
Copy link
Contributor

amel-unity commented Jan 11, 2021

Hi @DSivtsov! I just merged this PR to replace the current tool as mentioned in the thread so I will need to close this PR. Thanks a lot again for helping with this task.
Also, feel free to open another PR if you have ideas to improve the new tool.

@amel-unity amel-unity closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool A PR that contains an Editor tool or custom Inspectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants