Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): broken CI & code stuff after project name change #152

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

adhirajsinghchauhan
Copy link
Contributor

@adhirajsinghchauhan adhirajsinghchauhan commented Jan 4, 2024

We should've reviewed #124 more carefully, as most of this PR is in reaction to it.

Fixed:

  • feat: rename project name to Universal Android Debloater Next Generation (UAD-ng) #124 changed cache/log directory to uad-ng, which I don't think we wanted (can be argued as bloat).
    Continuing to use uad would be preferable as users would have to manually delete the old one otherwise.
  • The build_artifacts & release workflows were broken because they still used uad_gui.
  • Log-level configuration for our own crate (uad) still used uad_gui

Additional changes in this PR:

  • release workflow will no longer run at all on a normal push
    This workflow just creates pre-releases if we've pushed a tag. However, with the previous configuration, only the sub-step of creating a release was skipped, but the other steps for building & downloading artifacts were running every single time even if it was a normal push (i.e. not a tag). This was wasteful and noisy.
  • fine-tuned ci workflow path configuration
    Earlier, this would run even if JSON files like icons.json and uad_lists.json changed, but neither of these files are part of the build itself. This was also wasteful/noisy.

@adhirajsinghchauhan adhirajsinghchauhan merged commit 9785944 into main Jan 4, 2024
16 checks passed
@adhirajsinghchauhan adhirajsinghchauhan deleted the fix/broken-things-after-name-change branch January 4, 2024 02:57
adhirajsinghchauhan added a commit that referenced this pull request Jan 4, 2024
This should've been part of #152, but oh well.
adhirajsinghchauhan added a commit that referenced this pull request Jan 8, 2024
This should've been part of #152, but oh well.
@AnonymousWP AnonymousWP added the bug Something isn't working label Feb 6, 2024
@AnonymousWP AnonymousWP changed the title Fix broken CI & code stuff after project name change fix: broken CI & code stuff after project name change Feb 6, 2024
@Frigyes06 Frigyes06 changed the title fix: broken CI & code stuff after project name change fix(ci): broken CI & code stuff after project name change Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants