Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPPO more packages #253

Closed
wants to merge 1 commit into from
Closed

OPPO more packages #253

wants to merge 1 commit into from

Conversation

Blitz517
Copy link
Contributor

No description provided.

@Blitz517 Blitz517 added the package::addition Adding new apps to the debloat list label Feb 13, 2024
Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this big PR. I left some comments and made some suggestions. Please check them carefully.

@@ -37484,6 +37484,9 @@
"id": "com.qualcomm.qti.gpudrivers.taro.api31",
"list": "Misc",
"description": "Adreno Graphics Drivers\nGPU drivers",
"id": "com.oplus.battery",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://xdaforums.com/t/how-to-fix-oneplus-11-thermal-throttling.4560085/post-89255314, com.oplus.battery isn't directly related to the battery (firmware) itself.

Hi guys, what are the side effects of disabling com.oplus.battery? Does the app control other things? I'm worried that disabling it can remove all the smart optimization for the battery and make it discharge faster, even in condition of low stress, am i wrong? Someone that have done it can tell me if disabling it lead to lose other function? Thank you very much.

Nothing is affected all works fine, you just can't optimise apps after disabling battery app.

What do you think of Expert instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think to better give a link to this xda forum and from unsafe to expert for people to test it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, please do that.

@@ -37484,6 +37484,9 @@
"id": "com.qualcomm.qti.gpudrivers.taro.api31",
"list": "Misc",
"description": "Adreno Graphics Drivers\nGPU drivers",
"id": "com.oplus.battery",
"list": "Oem",
"description": "Battery\nNeeded for power managment in settings.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. Description will have to be edited too.

resources/assets/uad_lists.json Show resolved Hide resolved
{
"id": "com.oplus.cota",
"list": "Oem",
"description": "Carrier settings update?\nLooks like a more Software Updates.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Carrier settings update?\nLooks like a more Software Updates.",
"description": "Carrier software updater?\nLooks like software updater for carrier phones.",

@@ -37520,6 +37538,18 @@
"id": "com.motorola.overlay.googleasi",
"list": "Oem",
"description": "Overlay to Android System Intelligence 'com.google.android.as',\nremoval means that you cannot use the features of this app probably.",
"id": "com.oplus.engineermodeforflipkart",
"list": "Oem",
"description": "Engineermode2\nShows Sar IMEI.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also related to FlipKart? See package name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its for get flipkartAddress and ShowSarImeiReceiver
Head SAR: %1$s W/kg
Body SAR: %2$s W/kg
%3$s
This phone is part of Flipkart Smart Plan and not eligible for release till any instant advance amount availed is repaid. Visit %4$s for more information

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and theres random big text about Flipkart ^^^

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is worth mentioning extra in the description field?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, with the next commit, please include it (including all other suggestions we agreed upon).

"dependencies": [],
"neededBy": [],
"labels": [],
"removal": "Recommended"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"removal": "Recommended"
"removal": "Expert"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe advanced?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, why? Gestures are a vital and widespread part of the system.

resources/assets/uad_lists.json Show resolved Hide resolved
{
"id": "com.oplus.virtualcomm",
"list": "Oem",
"description": "It's probably virtual communications.\nAlso about these it's in the code.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Virtual communications. Isn't that important then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk men this app has no activities, no permissions, only some code in classes.dex theres dmtp client things and virtualcomm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not sure, I think you should change it to Advanced.

{
"id": "com.oplus.subsys",
"list": "Oem",
"description": "Its app for virtual communication. Depends on 'com.oplus.virtualcomm'.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Virtual communications. Isn't that important then?

"dependencies": [],
"neededBy": [],
"labels": [],
"removal": "Recommended"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"removal": "Recommended"
"removal": "Advanced"

Some people may want to use it, so I think Advanced should make more sense.

@AnonymousWP
Copy link
Member

Superseded & resolved by #273.

@AnonymousWP AnonymousWP deleted the Blitz517-patch-3 branch February 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package::addition Adding new apps to the debloat list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants