pkg: add Xiaomi packages and improve documentation/removals of some other packages #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more information, less disinformation
Blitz517
added
package::documentation
AnonymousWP
changed the title
AnonymousWP
changed the title
AnonymousWP
requested changes
Mar 21, 2024
| @@ -9562,11 +9562,11 @@ | |||
| }, | |||
| "com.qualcomm.qti.improvetouch.service": { | |||
| "list": "Misc", | |||
| "description": "In code I found only something about touchprocessor and it does not look useless,\nIt just should improve touch but not sure if it's only for developers.", | |||
| "description": "A improve touch things was found in the code, but it is not available to users, only to developers.\nThe size of the app is 36.40 KB, so why would this improve touch?\nThis app does not exist on some xiaomi phones, and the touch works the same.", | |||
There was a problem hiding this comment.
Suggested change
| "description": "A improve touch things was found in the code, but it is not available to users, only to developers.\nThe size of the app is 36.40 KB, so why would this improve touch?\nThis app does not exist on some xiaomi phones, and the touch works the same.", | |
| "description": "A package to improve touch-related things were found in the code, but it is not available to users, only to developers.\nThe size of the app is 36.40 KB, so why would this improve touch?\nThis app does not exist on some Xiaomi phones, and the touch works the same.", |
To be honest, the app size doesn't say much, because code is just small in size and doesn't contain assets like images or so. Seems to be useful, see: https://www.reddit.com/r/Android/comments/3ibqs3/understanding_qualcomms_improvetouch/
There was a problem hiding this comment.
so thats it, advanced
| @@ -10306,7 +10306,7 @@ | |||
| "dependencies": [], | |||
| "neededBy": [], | |||
| "labels": [], | |||
| "removal": "Expert" | |||
| "removal": "Advanced" | |||
There was a problem hiding this comment.
Suggested change
| "removal": "Advanced" | |
| "removal": "Expert" |
VoWiFi/VoLTE is a pretty significant feature to be honest, I wouldn't set it to Advanced. It doesn't hurt at all either.
There was a problem hiding this comment.
but some apps for vowifi or volte was already set advanced
There was a problem hiding this comment.
Then that should be corrected too in my opinion.
| @@ -12870,7 +12870,7 @@ | |||
| "dependencies": [], | |||
| "neededBy": [], | |||
| "labels": [], | |||
| "removal": "Expert" | |||
| "removal": "Advanced" | |||
There was a problem hiding this comment.
Suggested change
| "removal": "Advanced" | |
| "removal": "Expert" |
See above.
AnonymousWP
changed the title
AnonymousWP
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more information, less disinformation