feat(backup): re-add export selection to text file #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
- added back possibility to export current selection to txt file - on successful export show modal
lavafroth
reviewed
May 3, 2024
| .padding(10) | ||
| .style(style::Container::Frame); | ||
|
|
||
| return Modal::new(content.padding(10), ctn) |
There was a problem hiding this comment.
We might not need the explicit return here. Just a nit though.
lavafroth
reviewed
May 3, 2024
| @@ -116,6 +119,7 @@ impl List { | |||
| Message::ModalHide => { | |||
| self.selection_modal = false; | |||
There was a problem hiding this comment.
Now that we have so many modals, we might be better off with creating some sort of enum like self.focused_modal = Modal::Selection and then match upon that. Anyways, you don't have to implement it here. Let's do that in a separate commit / PR.
lavafroth
approved these changes
May 3, 2024
You're right. Will do that in core/DRY branch, since I already started on cleaning and tidying the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added back possibility to export current selection to txt file
on successful export show modal
Resolves #300