Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/DRY: don't repeat yourself #437

Merged
merged 1 commit into from
May 2, 2024
Merged

core/DRY: don't repeat yourself #437

merged 1 commit into from
May 2, 2024

Conversation

edgy-b
Copy link
Contributor

@edgy-b edgy-b commented Apr 29, 2024

  • added wrapper function for button

  • removed Refresh style, as basically it was styled same as Primary

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Apr 29, 2024 •
edited
Loading

Here's the code health analysis summary for commits 8c55879..2335e84. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ Success
❗ 5 occurences introduced
🎯 4 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ Success
❗ 46 occurences introduced
🎯 62 occurences resolved
View Check ↗

Code Coverage Report

MetricAggregateRust
Branch Coverage100%0%
Composite Coverage1.9%1.9%
Line Coverage1.9%1.9%
New Branch Coverage100%100%
New Composite Coverage2.8%2.8%
New Line Coverage2.8%2.8%
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@edgy-b
core/DRY: don't repeat yourself
2335e84 
 - added wrapper function for button

 - removed Refresh style, as basically it was styled same as Primary
@edgy-b edgy-b requested a review from a team May 2, 2024 12:25
lavafroth
lavafroth approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@lavafroth lavafroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I've been planning to do myself. Thank you, looks really good!

@lavafroth lavafroth merged commit 2205451 into main May 2, 2024
21 checks passed
@adhirajsinghchauhan adhirajsinghchauhan deleted the core/DRY branch May 2, 2024 17:02
@AnonymousWP
Copy link
Member

AnonymousWP commented May 4, 2024 •
edited
Loading

@edgy-b Please edit the title. @Universal-Debloater-Alliance/developers Why has nobody picked this up upon reviewing though? This title doesn't align with our guidelines. Neither did anyone add a label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavafroth lavafroth lavafroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edgy-b @AnonymousWP @lavafroth