Add generation 3 save support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix wrong pixel in listBg, change "Back" to "Ok" in prompts, and make colors an enum class
and don't update the OAM until after the sprite has moved when closing
(WIP because the top bars need additional palettes so I'll do 2 images)
~~I was lazy and didn't test the last one~~
(last commit only working on Sapphire (J)) Also tint the Slot-1: (No card inserted) message red
Also: - Make drawRectangle() not use DMA, may add deticated DMA draw later - Add warn for bad cardridge type on write - Convert red box warnings to warns - Make `Ok` button on prompt/warn dynamically sized
(aka I need to reboot to win10 so I can build PKHeX)
probably wrong since everything that's edited is a bad egg currently
is mostly working
image title bars
Note: PK4+ → PK3 does not transfer ribbons or trash bytes currently
(I'll probably make it better later)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds generation 3 support and switches the core to use a submodule shared with PKSM.
(and also most of the misc things I've done recently)