Change logger based on suggestions from @firstone #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firstone
approved these changes
Apr 7, 2020
|
|
||
| class PolyLogger: | ||
|
|
||
| NAME = __name__.split(".")[0] |
There was a problem hiding this comment.
I'm not sure about purpose of this. I believe name here will resolve to "polylogger", that is, module name, rather than the name of executable that invoked. Was that the intent? If so, there's no need for split.
There was a problem hiding this comment.
No, name is polyinterface.polylogger so I just wanted polyinterface which was what you get when it's inside init like I had before. I could leave it hardcoded like you had it, but this works as well.
There was a problem hiding this comment.
It's fine. Just slightly confusing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly worked right of the box, thanks @firstone Seems like a much cleaner method. Let me know what you all think.