Zeroconf transcoding #987
Closed
Zeroconf transcoding #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 1, 2016 22:17
- Implemented start and count for search
- Tested WMP, Denon 2113, BubbleUPnP, XBox (no content navigation)
- Xbox escapes quotes in search criteria
added 22 commits
November 4, 2016 14:56
- auto increment id for AUDIOTRACKS and SUBTRACKS
|
For people who are watching this, here's some bug fixes. |
Sami32
reviewed
Jan 12, 2017
| @@ -422,7 +422,7 @@ public static boolean isSupportedMimetype(String mimetype) { | |||
| if ("audio/L24".equalsIgnoreCase(mimetype) | |||
| || "video/vnd.dlna.mpeg-tts".equalsIgnoreCase(mimetype) | |||
| || "video/mpeg2".equalsIgnoreCase(mimetype) | |||
| || "audio/vnd.dlna.adts".equals(mimetype) | |||
| || "audio/vnd.dlna.adts".equalsIgnoreCase(mimetype) | |||
There was a problem hiding this comment.
Defining mimetype as lower or upper case should "clean" the code as all equalsIgnoreCase could be replaced by equals
There was a problem hiding this comment.
@Sami32 That will result in less robust code - anyone edition will have to know/remember this rule or create a bug. A much better solution (imo) is to use Enum for things like that, it's type-safe and evaluation is much quicker.
valib
added a commit
that referenced
this pull request
Aug 22, 2017
|
Feel free to resurrect |
|
@atamariya there was some awesome stuff in here... |
SubJunk
added a commit
that referenced
this pull request
May 30, 2020
* Revert Netty to 4.0.29 * Updated Netty to 4.0.32 * Fixed MPEG1 video format detection. * Update to the latest Netty 4 version * Updated Netty implementation * Update the Netty implementation continues * Removed unused import * Check subtitles only once to speed up browsing * Some change * Updated Netty to 4.1.1 * Keep doing Cling searches * Formatting * Update netty * Fixed merging * Add the 'end of content' marker for chunked transfer based on #987 * Fixed bug reported by @Sami32 and cleans up RequestHandlerV2 based on the #462 (thanks @mfulgo) * Update Netty version and fix some bugs * Updated to latest Netty version * Update to the latest Netty version * Bump Netty * Update * update * Removed old code * Log if stream is chunked * fix merging * Updated to the latest version * Update src/main/java/net/pms/network/RequestHandlerV2.java Co-authored-by: SubJunk <SubJunk@users.noreply.github.com> Co-authored-by: SubJunk <subjunk@gmail.com> Co-authored-by: SubJunk <SubJunk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, UMS queries the device capapbilities (GetProtocolInfo) and accordingly streams or transcodes the media. So far I've tested it on WMP 12, Denon 2113 and XBox 360. However, it's still beta code. While I was at it, I also added some features that I'd wanted.
curl localhost:5001/get/27/a.mp4 -o a.mp4to download an mp4 version of the media.
Edit:
Demo http://lifeofpenguin.blogspot.com/2016/08/streaming-home-media-via-upnp.html
This change is