Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile for the driver #105

Merged
merged 3 commits into from
May 10, 2021
Merged

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented May 7, 2021

* Updated README to reflect transfer to Universal Robots GitHub
Copy link
Member

@urrsk urrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ur_robot_driver/resources/Dockerfile Outdated Show resolved Hide resolved
Change ENV to ARG for  the colcon workspace
Use WORKDIR instead of mkdir && cd

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
@urrsk
Copy link
Member

urrsk commented May 7, 2021

@gavanderhoorn great suggestions.
Do you have additional inputs?

@urrsk urrsk merged commit 53ee6b0 into UniversalRobots:main May 10, 2021
@urmahp urmahp deleted the add_dockerfile branch May 10, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants