Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tf prefix properly #688

Merged
merged 2 commits into from May 24, 2023
Merged

Use tf prefix properly #688

merged 2 commits into from May 24, 2023

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented May 24, 2023

Since UniversalRobots/Universal_Robots_ROS2_Description#66 is merged, we'll have to revert the workaround in the driver as well.

@fmauch
Remove tf_prefix workaround in hw interface
654fee2 
ros2_control can now accept empty parameters, so this isn't needed anymore.
@fmauch
Build ros2_control from master / humble branch until next sync
879395b 
Accepting empty params isn't yet released.
firesurfer
firesurfer approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@firesurfer firesurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be fine

@RobertWilbrandt RobertWilbrandt merged commit 7cda9c1 into UniversalRobots:main May 24, 2023
4 of 7 checks passed
@fmauch fmauch deleted the use_tf_prefix_properly branch May 24, 2023 14:36
@fmauch fmauch mentioned this pull request May 24, 2023
Merged
@firesurfer
Copy link
Contributor

@fmauch I just realized we forgot to remove the workaround also in the export_command_interfaces

@fmauch
Copy link
Collaborator Author

fmauch commented May 25, 2023

I'm ooo until Tuesday, but I'll try to have a look at this tomorrow or Saturday.

@firesurfer
Copy link
Contributor

Added a PR for it #692

@firesurfer firesurfer mentioned this pull request May 25, 2023
Closed
@fmauch
Copy link
Collaborator Author

fmauch commented Jun 23, 2023

@Mergifyio backport humble

@mergify
Copy link

mergify bot commented Jun 23, 2023 •
edited

backport humble

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jun 23, 2023
Merged
fmauch pushed a commit that referenced this pull request Jun 23, 2023
@mergify
Use tf prefix properly (backport #688) (#725)
7014d93 
Remove tf_prefix workaround in hw interface

ros2_control can now accept empty parameters, so this isn't needed anymore.

Co-authored-by: Lennart Nachtigall <lennart.nachtigall@sci-mo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertWilbrandt RobertWilbrandt RobertWilbrandt approved these changes

@firesurfer firesurfer firesurfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmauch @firesurfer @RobertWilbrandt