Fix multi-line strings in DeclareLaunchArgument #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthijsBurgh
changed the title
MatthijsBurgh
force-pushed
the
fix/declare_launch_argument
branch
from
ba9689a
to
d623a4f
Compare
|
Can you please provide a short justification for why this is better? Both versions seem to work equally well for me, and e.g. |
|
Sorry for not provinding a motivation. This removes the whitespace from the argument descriptions. (Another option is removing the indent from the 2nd, 3rd, etc line. But I think this is better.) |
|
@RobertWilbrandt friendly ping |
1 similar comment
|
@RobertWilbrandt friendly ping |
MatthijsBurgh
force-pushed
the
fix/declare_launch_argument
branch
from
d623a4f
to
3937e3c
Compare
fmauch
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
This looks good. Thank you @MatthijsBurgh for taking the time to implement this.
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* (driver) fix multi-line strings in DeclareLaunchArgument * (moveit) fix multi-line strings in DeclareLaunchArgument (cherry picked from commit d16eaba) # Conflicts: # ur_robot_driver/launch/ur10.launch.py # ur_robot_driver/launch/ur10e.launch.py # ur_robot_driver/launch/ur16e.launch.py # ur_robot_driver/launch/ur20.launch.py # ur_robot_driver/launch/ur3.launch.py # ur_robot_driver/launch/ur30.launch.py # ur_robot_driver/launch/ur3e.launch.py # ur_robot_driver/launch/ur5.launch.py # ur_robot_driver/launch/ur5e.launch.py # ur_robot_driver/launch/ur_control.launch.py
mergify bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
* (driver) fix multi-line strings in DeclareLaunchArgument * (moveit) fix multi-line strings in DeclareLaunchArgument (cherry picked from commit d16eaba) # Conflicts: # ur_robot_driver/launch/ur10.launch.py # ur_robot_driver/launch/ur10e.launch.py # ur_robot_driver/launch/ur16e.launch.py # ur_robot_driver/launch/ur20.launch.py # ur_robot_driver/launch/ur3.launch.py # ur_robot_driver/launch/ur30.launch.py # ur_robot_driver/launch/ur3e.launch.py # ur_robot_driver/launch/ur5.launch.py # ur_robot_driver/launch/ur5e.launch.py # ur_robot_driver/launch/ur_control.launch.py
fmauch
pushed a commit
that referenced
this pull request
Apr 15, 2024
* (driver) fix multi-line strings in DeclareLaunchArgument * (moveit) fix multi-line strings in DeclareLaunchArgument (cherry picked from commit d16eaba)
fmauch
pushed a commit
that referenced
this pull request
Apr 15, 2024
* (driver) fix multi-line strings in DeclareLaunchArgument * (moveit) fix multi-line strings in DeclareLaunchArgument (cherry picked from commit d16eaba)
fmauch
pushed a commit
that referenced
this pull request
Apr 15, 2024
fmauch
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
UniversalRobots/Universal_Robots_ROS2_Description#140
UniversalRobots/Universal_Robots_ROS2_Gazebo_Simulation#59
UniversalRobots/Universal_Robots_ROS2_GZ_Simulation#16