Remove dependency to docker.io #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default. So, in order to not install docker for users automatically, the dependency shall be removed.
RobertWilbrandt
approved these changes
May 7, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Remove dependency to docker.io The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default. So, in order to not install docker for users automatically, the dependency shall be removed. (cherry picked from commit 585e29f) # Conflicts: # .github/workflows/reusable_ici.yml
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
* Remove dependency to docker.io The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default. So, in order to not install docker for users automatically, the dependency shall be removed. (cherry picked from commit 585e29f)
fmauch
added a commit
that referenced
this pull request
May 7, 2024
* Remove dependency to docker.io The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default. So, in order to not install docker for users automatically, the dependency shall be removed. (cherry picked from commit 585e29f)
fmauch
pushed a commit
that referenced
this pull request
May 7, 2024
* Remove dependency to docker.io The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default. So, in order to not install docker for users automatically, the dependency shall be removed.
fmauch
added a commit
that referenced
this pull request
May 7, 2024
The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default. So, in order to not install docker for users automatically, the dependency shall be removed. (cherry picked from commit 585e29f) Co-authored-by: Felix Exner (fexner) <exner@fzi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency was basically added since this is needed to spawn up ursim. However, the start_ursim script catches the case that no docker executable is available and the tests requiring it are behind a compile definition which is off by default.
So, in order to not install docker for users automatically, the dependency shall be removed.
As a side-effect this has always stopped us from releasing the package for RHEL.
This closes #769