4 admin page ish but async await makes this to be just a empty promise #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple <form> page behind basic auth where the user could enable courses that are not activated yet. This shit got stuck at the typical javascript async await so to expand this behaviour to real life then this clearly is promised to be done and may or may not get done in time.
…th for user admin with password set in env ADMIN_PW variable.
… from upstream.
Problems:
* Some courses might not have teacher at their creation lol
* I bet that there are many more
TODO:
-> Create the course CourseInstance.create
-> find each teacher user and create with incomplete data (findOrCreate by username).
-> Use each created user id to link the user with the CourseInstance.
Finally, check that the login function fills in missing data for users...... and somehow also teacher memberships.
|
TeacherInstance link creation fixed |
changing this back to how you use this by default.
typo
|
Aslo has now a middleware that tells the user that ADMIN_PW environment variable needs to be set if unset. |
* commented out and removed some console.log calls * removed one too many res.send from courseinstances controller
…_makes_this_to_be_just_a_empty_promise' into 4_admin_page_ish_but_async_await_makes_this_to_be_just_a_empty_promise
travis var to be correct.
Jest should be used since it is able to return exit code 0 for success and 1 for failure.
…be run in travis. Like first in order is the tests stage after which integration tests should be run.
pumm1
reviewed
Apr 20, 2018
| const authorization = request.get('authorization') | ||
| if (authorization && authorization.toLowerCase().startsWith('bearer ')) { | ||
| request.token = authorization.substring(7) | ||
| } else { | ||
| } | ||
|
|
There was a problem hiding this comment.
Why is there if-else with empty else-statetment?!
pumm1
reviewed
Apr 20, 2018
| } | ||
| } else { | ||
| } |
|
seems to work as intended after fixing some os based problems |
tjunno
approved these changes
Apr 20, 2018
ruupert
deleted the
4_admin_page_ish_but_async_await_makes_this_to_be_just_a_empty_promise
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Adds middlewares for checking env variables TOKEN and SECRET at the start and stop processing any requests any further if they are not set.
Adds backend /admin page with a single purpose of activating/importing courses from upstream server to the application. Uses pug for views and http basic auth with username admin and password from the env variable ADMIN_PW. TODO: add another middleware to check that the ADMIN_PW is set or otherwise it might let in without password.
Adding courses works as following: Get courses for current and next term and select all courses matching from the DB and work out which of them isn't added. From those not added courses a pug page is rendered with a form for each not added course with a submit button, which posts the form values and they are entered into the DB as they are and while at it the course teachers user entries (with only username value) are added. This tries to insert into TeacherInstances appropriate links but currently FAILS in inserting the userId for some reason.
This should not break anything currently in the dev branch.
I have: