Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for fallback-action #93

Merged
merged 11 commits into from
Dec 6, 2019
Merged

feat: Add support for fallback-action #93

merged 11 commits into from
Dec 6, 2019

Commits on Nov 12, 2019

  1. relates to Unleash#89: to Added first implementation (draft) of fallb… 

    …ackAction
    Dennis Menge committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    a4b2c44 View commit details
    Browse the repository at this point in the history

  2. Migrated to BiFunction for definition of fallback action, refactored … 

    …methods according to feedback, added tests
    @dennis-menge
    dennis-menge committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    548b9b7 View commit details
    Browse the repository at this point in the history

  3. changed one test case to reflect correct implementation

    @dennis-menge
    dennis-menge committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    63b1621 View commit details
    Browse the repository at this point in the history

  4. Added default implementation for isEnabled(String, BiFunction)

    @dennis-menge
    dennis-menge committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    d6057c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2019

  1. Incorporated feedback, changed logical method layout in DefaultUnleas… 

    …h implementation, added default implementation in Unleash interface to avoid breaking existing implementation
    @dennis-menge
    dennis-menge committed Nov 13, 2019
    Configuration menu
    Copy the full SHA
    b731dba View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. fix: fallbackAction and defaultSetting 

    Should not be possible to define both a fallback action and
a defaultSetting at the same time.
    ivaosthu committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    e96a173 View commit details
    Browse the repository at this point in the history

  2. fix: Improve fallbackAction unit-tests 

    Use mocked functions and verify that the fallBack action
is actually called with correct arguments.
    ivaosthu committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    b4c8712 View commit details
    Browse the repository at this point in the history

  3. fix: remove final arguments in interface

    ivaosthu committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    2e8bfcc View commit details
    Browse the repository at this point in the history

  4. fix: simplify FakeUnleash for fallbackAction

    ivaosthu committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    2b7ac49 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. fix: formatting

    ivaosthu committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    5dc0061 View commit details
    Browse the repository at this point in the history

  2. fix: counting at right place

    ivaosthu committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    e0eb435 View commit details
    Browse the repository at this point in the history