Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: breaking yarn change for pnpm coop #62

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

kwasniew
Copy link
Collaborator

@kwasniew kwasniew commented Feb 12, 2024

About the changes

yarn 1.21.21 introduces breaking change with pnpm + yarn used together:
yarnpkg/yarn#9015 and actions/setup-node#899. Before we switch to yarn and remove pnpm I added a workaround so that we can release new versions.

The env var should disabled a breaking change that was added after 1.21.19 (last version that was working for us):
https://github.com/yarnpkg/yarn/blob/1.22-stable/src/cli/index.js#L292C21-L292C33

Important files

Discussion points

@kwasniew kwasniew requested a review from Tymek February 12, 2024 12:33
@kwasniew kwasniew merged commit 4227315 into main Feb 12, 2024
6 checks passed
@kwasniew kwasniew deleted the workaround-for-breaking-yarn-change branch February 12, 2024 15:24
renovate bot added a commit to simonknittel/simonknittel.de that referenced this pull request Feb 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs)
| [`1.3.0` ->
`1.4.0`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.3.0/1.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@unleash%2fnextjs/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@unleash%2fnextjs/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@unleash%2fnextjs/1.3.0/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@unleash%2fnextjs/1.3.0/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Unleash/unleash-client-nextjs
(@&#8203;unleash/nextjs)</summary>

###
[`v1.4.0`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.4.0)

[Compare
Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.3.0...v1.4.0)

#### What's Changed

- feat: add feature_enabled to variant response by
[@&#8203;nunogois](https://togithub.com/nunogois) in
[Unleash/unleash-client-nextjs#58
- Update README.md by [@&#8203;tepose](https://togithub.com/tepose) in
[Unleash/unleash-client-nextjs#60
- chore: upgrade node client by
[@&#8203;kwasniew](https://togithub.com/kwasniew) in
[Unleash/unleash-client-nextjs#61
- fix: breaking yarn change for pnpm coop by
[@&#8203;kwasniew](https://togithub.com/kwasniew) in
[Unleash/unleash-client-nextjs#62
- chore: remove package manager from package json by
[@&#8203;kwasniew](https://togithub.com/kwasniew) in
[Unleash/unleash-client-nextjs#63
- fix: Upgrade vulnerable IP package by
[@&#8203;danilofuchs](https://togithub.com/danilofuchs) in
[Unleash/unleash-client-nextjs#65

#### New Contributors

- [@&#8203;nunogois](https://togithub.com/nunogois) made their first
contribution in
[Unleash/unleash-client-nextjs#58
- [@&#8203;tepose](https://togithub.com/tepose) made their first
contribution in
[Unleash/unleash-client-nextjs#60
- [@&#8203;kwasniew](https://togithub.com/kwasniew) made their first
contribution in
[Unleash/unleash-client-nextjs#61
- [@&#8203;danilofuchs](https://togithub.com/danilofuchs) made their
first contribution in
[Unleash/unleash-client-nextjs#65

**Full Changelog**:
Unleash/unleash-client-nextjs@v1.3.0...v1.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/simonknittel/simonknittel.de).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
simonknittel pushed a commit to simonknittel/sinister-incorporated that referenced this pull request Feb 29, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@unleash/nextjs](https://togithub.com/Unleash/unleash-client-nextjs)
| [`1.3.0` ->
`1.4.0`](https://renovatebot.com/diffs/npm/@unleash%2fnextjs/1.3.0/1.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@unleash%2fnextjs/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@unleash%2fnextjs/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@unleash%2fnextjs/1.3.0/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@unleash%2fnextjs/1.3.0/1.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>Unleash/unleash-client-nextjs
(@&#8203;unleash/nextjs)</summary>

###
[`v1.4.0`](https://togithub.com/Unleash/unleash-client-nextjs/releases/tag/v1.4.0)

[Compare
Source](https://togithub.com/Unleash/unleash-client-nextjs/compare/v1.3.0...v1.4.0)

#### What's Changed

- feat: add feature_enabled to variant response by
[@&#8203;nunogois](https://togithub.com/nunogois) in
[Unleash/unleash-client-nextjs#58
- Update README.md by [@&#8203;tepose](https://togithub.com/tepose) in
[Unleash/unleash-client-nextjs#60
- chore: upgrade node client by
[@&#8203;kwasniew](https://togithub.com/kwasniew) in
[Unleash/unleash-client-nextjs#61
- fix: breaking yarn change for pnpm coop by
[@&#8203;kwasniew](https://togithub.com/kwasniew) in
[Unleash/unleash-client-nextjs#62
- chore: remove package manager from package json by
[@&#8203;kwasniew](https://togithub.com/kwasniew) in
[Unleash/unleash-client-nextjs#63
- fix: Upgrade vulnerable IP package by
[@&#8203;danilofuchs](https://togithub.com/danilofuchs) in
[Unleash/unleash-client-nextjs#65

#### New Contributors

- [@&#8203;nunogois](https://togithub.com/nunogois) made their first
contribution in
[Unleash/unleash-client-nextjs#58
- [@&#8203;tepose](https://togithub.com/tepose) made their first
contribution in
[Unleash/unleash-client-nextjs#60
- [@&#8203;kwasniew](https://togithub.com/kwasniew) made their first
contribution in
[Unleash/unleash-client-nextjs#61
- [@&#8203;danilofuchs](https://togithub.com/danilofuchs) made their
first contribution in
[Unleash/unleash-client-nextjs#65

**Full Changelog**:
Unleash/unleash-client-nextjs@v1.3.0...v1.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/simonknittel/sinister-incorporated).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIxMi4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants