feat: add support for new constraint operators #289
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/strategy/strategy.ts
Outdated
| } | ||
| default: | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Instead of a switch on the Operator-enum I am tempted to instead create a small handler function per operator and just execute that function.
Example for contains:
const handler = (values: string[], contextValue) =>
values.some((val) => contextValue.includes(val.trim()))There was a problem hiding this comment.
Also, we should probably pre-map the values by trimming them, making the handler work on pure data.
values.map((v) => v.trim())
src/helpers.ts
Outdated
|
|
||
| const prefix = info | ||
| ? info.username | ||
| : `generated-${Math.round(Math.random() * 1000000)}-${process.pid}`; |
There was a problem hiding this comment.
opt.semgrep.node_insecure_random_generator: crypto.pseudoRandomBytes()/Math.random() is a cryptographically weak random number generator.
(at-me in a reply with help or ignore)
ivarconr
force-pushed
the
feat/constrain-operators
branch
from
b8b57ef
to
b697e11
Compare
| const DateOperator = (constraint: Constraint, context: Context) => { | ||
| const { operator } = constraint; | ||
| const value = new Date(constraint.value as string); | ||
| const currentTime = context.currentTime ? new Date(context.currentTime) : new Date(); |
There was a problem hiding this comment.
we might want to move this to the creation of the context.
(+) The benefit will be that the date and time will not change between multiple constriants within the same feature toggle.
(-) The downside would be that we would have to create the currentTime date instance on the context, even when a use is not using any constraints that uses date operators.
ivarconr
force-pushed
the
feat/constrain-operators
branch
from
5e8bc8a
to
24ed1ed
Compare
No description provided.