-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for new constraint operators #289
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7f5f345
feat: add support for new constraint operators
ivarconr 950ef91
fix: revert simple usage
ivarconr cd50ed5
fix: simplify swtich/case
ivarconr b0d1051
fix: more operators
ivarconr 5532915
fix: add example for context fields
ivarconr b7abafd
feat: add support for new constraint operators
ivarconr efc0c43
fix: revert simple usage
ivarconr d57cf5d
fix: refactor new constraint operators
ivarconr 8b99d72
fix: add support for date operators
ivarconr 0567876
fix: add support for semver ranges
ivarconr 8acee59
fix: cleanup code a bit
ivarconr 24ed1ed
fix: add updated client-specifications
ivarconr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
const { initialize, isEnabled } = require('../lib'); | ||
|
||
const client = initialize({ | ||
appName: 'my-application', | ||
url: 'http://localhost:4242/api/', | ||
refreshInterval: 1000, | ||
customHeaders: { | ||
Authorization: '*:development.7d9ca8d289c1545f1e28a6e4b2e25453c6cfc90346876ac7240c6668' }, | ||
}); | ||
|
||
client.on('error', console.error); | ||
client.on('warn', console.log); | ||
|
||
console.log('Fetching toggles from: http://unleash.herokuapp.com'); | ||
|
||
setInterval(() => { | ||
const toggle = 'TestOperator'; | ||
const context = { | ||
properties: { | ||
email: 'ivar@getunleash.ai', | ||
age: 37 | ||
} | ||
} | ||
const enabled = isEnabled(toggle, context); | ||
console.log(`${toggle}: ${enabled ? 'on' : 'off'}`); | ||
}, 1000); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to move this to the creation of the context.
(+) The benefit will be that the date and time will not change between multiple constriants within the same feature toggle.
(-) The downside would be that we would have to create the currentTime date instance on the context, even when a use is not using any constraints that uses date operators.