Fixes Unleash client stops fetching #615 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswk
previously approved these changes
May 22, 2024
There was a problem hiding this comment.
Thanks for this PR. Kinda worried about your server setup if you get intermittent 404s for a server instance, but I'll merge this since you added it to the backoff logic. At least we won't see the client get a 404 and therefore end up in a retry loop we did earlier.
|
Waiting for the build to go green before merging. |
|
The reason for the fail here was reported on client-specifications. Will bump to 5.1.6 on main, but will merge this. |
HenrikBacher
added a commit
to HenrikBacher/unleash-client-node
that referenced
this pull request
May 23, 2024
chriswk
pushed a commit
that referenced
this pull request
May 24, 2024
renovate bot
added a commit
to Unleash/unleash
that referenced
this pull request
Jun 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unleash-client](https://togithub.com/Unleash/unleash-client-node) | [`5.5.2` -> `5.5.3`](https://renovatebot.com/diffs/npm/unleash-client/5.5.2/5.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Unleash/unleash-client-node (unleash-client)</summary> ### [`v5.5.3`](https://togithub.com/Unleash/unleash-client-node/releases/tag/v5.5.3) [Compare Source](https://togithub.com/Unleash/unleash-client-node/compare/v5.5.2...v5.5.3) #### What's Changed - Making it clearer that the API token needs to be passed via custom headers by [@​alvinometric](https://togithub.com/alvinometric) in [Unleash/unleash-client-node#604 - Updated README to use ESM by [@​alvinometric](https://togithub.com/alvinometric) in [Unleash/unleash-client-node#605 - chore(deps): update dependency typescript to v5.4.5 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#600 - chore(deps): update dependency semver to v7.6.1 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#607 - chore(deps): update dependency sinon to v17.0.2 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#608 - chore(deps): bump tar from 6.1.13 to 6.2.1 by [@​dependabot](https://togithub.com/dependabot) in [Unleash/unleash-client-node#603 - chore(deps): update dependency sinon to v18 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#613 - chore(deps): update dependency semver to v7.6.2 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#612 - chore(deps): update dependency eslint to v8.57.0 by [@​renovate](https://togithub.com/renovate) in [Unleash/unleash-client-node#610 - Fixes Unleash client stops fetching [#​615](https://togithub.com/Unleash/unleash-client-node/issues/615) by [@​HenrikBacher](https://togithub.com/HenrikBacher) in [Unleash/unleash-client-node#616 #### New Contributors - [@​alvinometric](https://togithub.com/alvinometric) made their first contribution in [Unleash/unleash-client-node#604 - [@​HenrikBacher](https://togithub.com/HenrikBacher) made their first contribution in [Unleash/unleash-client-node#616 **Full Changelog**: Unleash/unleash-client-node@v5.5.2...v5.5.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am every weekday" in timezone Europe/Madrid, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Unleash/unleash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNzcuOCIsInVwZGF0ZWRJblZlciI6IjM3LjM3Ny44IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615 by treating http 404 as a recoverable error