fix: make proxy sdk respect cache ttl (#169)

Unleash · Aug 7, 2023 · fe05098 · fe05098
1 parent d249586
commit fe05098
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 1 deletion.
diff --git a/src/Repository/DefaultUnleashProxyRepository.php b/src/Repository/DefaultUnleashProxyRepository.php
@@ -69,7 +69,7 @@ public function findFeatureByContext(string $featureName, ?Context $context = nu
 
             if ($featureData !== null) {
                 if ($this->configuration->getCache() !== null) {
-                    $this->configuration->getCache()->set($cacheKey, $featureData);
+                    $this->configuration->getCache()->set($cacheKey, $featureData, $this->configuration->getTtl());
                 }
 
                 return new DefaultProxyFeature($featureData);

diff --git a/tests/Repository/DefaultUnleashProxyRepositoryTest.php b/tests/Repository/DefaultUnleashProxyRepositoryTest.php
@@ -21,6 +21,8 @@ final class DefaultUnleashProxyRepositoryTest extends AbstractHttpClientTest
 {
     use FakeCacheImplementationTrait, RealCacheImplementationTrait {
         FakeCacheImplementationTrait::getCache insteadof RealCacheImplementationTrait;
+
+        RealCacheImplementationTrait::getCache as getRealCache;
     }
 
     public function testNon200ResponseDegradesGracefully()
@@ -93,4 +95,59 @@ public function test200ResponseResolvesCorrectly()
         $this->assertTrue($resolvedFeature->isEnabled());
         $this->assertEquals($expectedVariant, $resolvedFeature->getVariant());
     }
+
+    public function testCacheTtlIsRespected()
+    {
+        $container = [];
+        $history = Middleware::history($container);
+        $response = json_encode([
+            'name' => 'test',
+            'enabled' => true,
+            'variant' => [
+                'name' => 'some-variant',
+                'payload' => [
+                    'type' => 'string',
+                    'value' => 'some-value',
+                ],
+                'enabled' => true,
+            ],
+            'impression_data' => false,
+        ]);
+
+        $mock = new MockHandler([
+            new Response(
+                200,
+                ['ETag' => 'etag value'],
+                $response
+            ),
+            new Response(
+                200,
+                ['ETag' => 'etag value'],
+                $response
+            ),
+        ]);
+
+        $handlerStack = HandlerStack::create($mock);
+        $handlerStack->push($history);
+
+        $client = new Client(['handler' => $handlerStack]);
+        $config = (new UnleashConfiguration('', '', ''))
+            ->setCache($this->getRealCache())
+            ->setProxyKey('some-key')
+            ->setTtl(1);
+
+        $requestFactory = new HttpFactory();
+        $repository = new DefaultUnleashProxyRepository($config, $client, $requestFactory);
+
+        $repository->findFeatureByContext('test');
+        //cache is still warm so this should fall back to that
+        $repository->findFeatureByContext('test');
+
+        sleep(1);
+
+        //ttl should have expired so this should trigger an API call
+        $repository->findFeatureByContext('test');
+
+        $this->assertCount(2, $container);
+    }
 }