Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Single value constraints #152

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

RikudouSage
Copy link
Collaborator

Description

Fixes a bug where single value constraints weren't evaluated at all.

Fixes #151

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for looking into this one. LGTM!

@RikudouSage RikudouSage merged commit cf3bf94 into main May 22, 2023
7 checks passed
@RikudouSage RikudouSage deleted the fix/single-value-constraints branch May 22, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Constraints check doesn't work
2 participants