feat: pre-live is non production not just dev (#6946)

Unleash · Apr 26, 2024 · 1739f8e · 1739f8e
1 parent 66ec9a2
commit 1739f8e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/lib/features/feature-lifecycle/feature-lifecycle-service.test.ts b/src/lib/features/feature-lifecycle/feature-lifecycle-service.test.ts
@@ -39,7 +39,7 @@ test('can insert and read lifecycle stages', async () => {
 
     await environmentStore.create({
         name: 'my-dev-environment',
-        type: 'development',
+        type: 'test',
     } as IEnvironment);
     await environmentStore.create({
         name: 'my-prod-environment',

diff --git a/src/lib/features/feature-lifecycle/feature-lifecycle-service.ts b/src/lib/features/feature-lifecycle/feature-lifecycle-service.ts
@@ -138,10 +138,9 @@ export class FeatureLifecycleService extends EventEmitter {
             if (!env) {
                 return;
             }
+            await this.stageReceivedMetrics(features, 'pre-live');
             if (env.type === 'production') {
                 await this.stageReceivedMetrics(features, 'live');
-            } else if (env.type === 'development') {
-                await this.stageReceivedMetrics(features, 'pre-live');
             }
         } catch (e) {
             this.logger.warn(

diff --git a/src/lib/features/feature-lifecycle/feature-lifecycle.e2e.test.ts b/src/lib/features/feature-lifecycle/feature-lifecycle.e2e.test.ts
@@ -136,6 +136,7 @@ test('should return lifecycle stages', async () => {
             stage: 'initial',
             enteredStageAt: expect.any(String),
         },
+        { stage: 'pre-live', enteredStageAt: expect.any(String) },
         {
             stage: 'live',
             enteredStageAt: expect.any(String),