-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre-live is non production not just dev #6946
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
@@ -134,7 +134,7 @@ export class FeatureLifecycleService extends EventEmitter { | |||
} | |||
if (env.type === 'production') { | |||
await this.stageReceivedMetrics(features, 'live'); | |||
} else if (env.type === 'development') { | |||
} else if (env.type !== 'production') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is weird, this is just else clause.
Also I think pre-live is also production, but toggle turned off.
So I would do
await this.stageReceivedMetrics(features, 'pre-live');
if (env.type === 'production') {
await this.stageReceivedMetrics(features, 'live');
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means, any metrics will put it to pre-live, any metrics in production puts it in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea
About the changes
Pre-live is not just development but also anything else that is not production.
Important files
Discussion points