fix: filter empty metrics before we collect last seen toggles. #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivarconr
commented
Oct 11, 2022
FredrikOseberg
approved these changes
Oct 13, 2022
|
|
||
| if (this.config.flagResolver.isEnabled('batchMetrics')) { | ||
| this.unsavedMetrics = collapseHourlyMetrics([ | ||
| ...this.unsavedMetrics, | ||
| ...clientMetrics, | ||
| ]); | ||
| this.lastSeenService.updateLastSeen(clientMetrics); |
There was a problem hiding this comment.
Should this just be the default?
There was a problem hiding this comment.
I prefer to have it behind a flag, and the batch flag seems natural.
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
FredrikOseberg
added a commit
that referenced
this pull request
Oct 17, 2022
* fix: filter empty metrics before we collect last seen toggles. fixes: #2104 * fix: add a last-seen service to batch last-seen toggle updates Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things related to lastSeen details for feature toggles.
yesornocount is larger than 0.batchMetrics. With the flag enabled lastSeen will only be updated every 30th second.fixes: #2104