-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter empty metrics before we collect last seen toggles. #2172
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5fb9bbc
fix: filter empty metrics before we collect last seen toggles.
ivarconr 473fa5e
fix: add a last-seen service to batch last-seen toggle updates
ivarconr e37dbea
fix: tests
ivarconr 05fe30b
fix: simplify tests
ivarconr b97cad0
Update src/lib/services/client-metrics/last-seen-service.ts
ivarconr 8d9ecf1
fix lint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
import { secondsToMilliseconds } from 'date-fns'; | ||
import { Logger } from '../../logger'; | ||
import { IUnleashConfig } from '../../server-impl'; | ||
import { IUnleashStores } from '../../types'; | ||
import { IClientMetricsEnv } from '../../types/stores/client-metrics-store-v2'; | ||
import { IFeatureToggleStore } from '../../types/stores/feature-toggle-store'; | ||
|
||
export class LastSeenService { | ||
private timers: NodeJS.Timeout[] = []; | ||
|
||
private lastSeenToggles: Set<string> = new Set(); | ||
|
||
private logger: Logger; | ||
|
||
private featureToggleStore: IFeatureToggleStore; | ||
|
||
constructor( | ||
{ featureToggleStore }: Pick<IUnleashStores, 'featureToggleStore'>, | ||
config: IUnleashConfig, | ||
lastSeenInterval = secondsToMilliseconds(30), | ||
) { | ||
this.featureToggleStore = featureToggleStore; | ||
this.logger = config.getLogger( | ||
'/services/client-metrics/last-seen-service.ts', | ||
); | ||
|
||
this.timers.push( | ||
setInterval(() => this.store(), lastSeenInterval).unref(), | ||
); | ||
} | ||
|
||
async store(): Promise<number> { | ||
const count = this.lastSeenToggles.size; | ||
if (count > 0) { | ||
const lastSeenToggles = [...this.lastSeenToggles]; | ||
this.lastSeenToggles = new Set(); | ||
this.logger.debug( | ||
`Updating last seen for ${lastSeenToggles.length} toggles`, | ||
); | ||
await this.featureToggleStore.setLastSeen(lastSeenToggles); | ||
} | ||
return count; | ||
} | ||
|
||
updateLastSeen(clientMetrics: IClientMetricsEnv[]): void { | ||
clientMetrics | ||
.filter( | ||
(clientMetric) => clientMetric.yes > 0 || clientMetric.no > 0, | ||
) | ||
.forEach((clientMetric) => | ||
this.lastSeenToggles.add(clientMetric.featureName), | ||
); | ||
} | ||
|
||
destroy(): void { | ||
this.timers.forEach(clearInterval); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to have it behind a flag, and the batch flag seems natural.