fix: fill the datasets with 0s when not enough data points #6793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Tymek
reviewed
Apr 8, 2024
| flex: 1, | ||
| maxWidth: '360px', | ||
| width: '100%', | ||
| zIndex: 100000, |
There was a problem hiding this comment.
Maybe we can avoid fixed numbers here? https://mui.com/material-ui/customization/z-index/
https://github.com/Unleash/unleash/blob/main/frontend/src/themes/theme.ts#L73-L75
There was a problem hiding this comment.
Sure, this was there. Feel free to adapt in a different PR. The point of this PR is to fill the chart data with 0s when no data for that datapoint
There was a problem hiding this comment.
Removed the zIndex. It's not needed
...t/insights/componentsChart/UpdatesPerEnvironmentTypeChart/UpdatesPerEnvironmentTypeChart.tsx
Outdated
Show resolved
Hide resolved
…ronmentTypeChart/UpdatesPerEnvironmentTypeChart.tsx Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Tymek
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills datasets that do not have all the datapoints with 0 so that every line in the graph starts at the beginning and ends at the end of graph.
Closes # 1-2256