Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add a separate feature flag for traffic visibility UI #6832

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

daveleek
Copy link
Contributor

About the changes

Adds a separate feature flag for the traffic data usage UI

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Apr 11, 2024 8:28am

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daveleek daveleek merged commit 88b5bfc into main Apr 11, 2024
16 checks passed
@daveleek daveleek deleted the chore/traffic-visibility-separate-ui-flag branch April 11, 2024 08:37
daveleek added a commit that referenced this pull request Apr 11, 2024
## About the changes

Adds a separate feature flag for the traffic data usage UI
daveleek added a commit that referenced this pull request Apr 11, 2024
…) (#6835)

## About the changes

cherry-picks adding the UI-flag for traffic visibility to 5.11

We're splitting the original `collectTrafficDataUsage` in two, one for
data collection and the new one introduced here is to allow the UI.

Showing the UI makes no sense if we haven't been collecting data, but
starting to collect data makes sense without showing the UI (docs,
training/information etc needed when showing the UI for enterprise
users), so the feature flag in Unleash is set to depend on data
collecting flag being enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants