feat: map project owners to projects list #6928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
thomasheartman
approved these changes
Apr 25, 2024
Comment on lines
20
to
55
| describe('unit tests', () => { | ||
| test('maps owners to projects', () => {}); | ||
| test('maps owners to projects', () => { | ||
| const projects = [{ name: 'project1' }, { name: 'project2' }] as any; | ||
|
|
||
| const owners = { | ||
| project1: [{ ownerType: 'user' as const, name: 'Owner Name' }], | ||
| project2: [{ ownerType: 'user' as const, name: 'Owner Name' }], | ||
| }; | ||
|
|
||
| const projectsWithOwners = ProjectOwnersReadModel.addOwnerData( | ||
| projects, | ||
| owners, | ||
| ); | ||
|
|
||
| expect(projectsWithOwners).toMatchObject([ | ||
| { name: 'project1', owners: [{ name: 'Owner Name' }] }, | ||
| { name: 'project2', owners: [{ name: 'Owner Name' }] }, | ||
| ]); | ||
| }); | ||
|
|
||
| test('returns "system" when a project has no owners', async () => { | ||
| // this is a mapping test; not an integration test | ||
| const projects = [{ name: 'project1' }, { name: 'project2' }] as any; | ||
|
|
||
| const owners = {}; | ||
|
|
||
| const projectsWithOwners = ProjectOwnersReadModel.addOwnerData( | ||
| projects, | ||
| owners, | ||
| ); | ||
|
|
||
| expect(projectsWithOwners).toMatchObject([ | ||
| { name: 'project1', owners: [{ ownerType: 'system' }] }, | ||
| { name: 'project2', owners: [{ ownerType: 'system' }] }, | ||
| ]); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Can be done later, but I think we should put the unit tests in a separate file? So we'll probably have project-owners-read-model.test.ts and project-owners-read-model.integration.test.ts. Feels like it jives better with what we're doing most the time.
There was a problem hiding this comment.
We have 3 types that correlate better to methods under test then to any specific test type. I think we can just describe what part of the class we are testing instead of moving it to a separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Follow-up for #6916
Internal ticket: https://linear.app/unleash/issue/1-2320/project-owners-mapping