Project owners read model - db read #6916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Tymek
commented
Apr 24, 2024
| return groupsDict; | ||
| } | ||
|
|
||
| async getAllProjectOwners(): Promise<ProjectOwnersDictionary> { |
There was a problem hiding this comment.
Splitting it in 2 private methods makes the main one more readable to me, so that's what I did
thomasheartman
approved these changes
Apr 25, 2024
Comment on lines
+125
to
+139
| const projects = [ | ||
| ...new Set([...Object.keys(usersDict), ...Object.keys(groupsDict)]), | ||
| ]; | ||
|
|
||
| const dict = Object.fromEntries( | ||
| projects.map((project) => { | ||
| return [ | ||
| project, | ||
| [ | ||
| ...(usersDict[project] || []), | ||
| ...(groupsDict[project] || []), | ||
| ], | ||
| ]; | ||
| }), | ||
| ); |
There was a problem hiding this comment.
This is optional, but there's a lot of spreading here. We're not necessarily doing it in a loop, but it's a lot more iterations than we need. How about doing something like this instead (coded in github, so might not work directly 😅 ):
Suggested change
| const projects = [ | |
| ...new Set([...Object.keys(usersDict), ...Object.keys(groupsDict)]), | |
| ]; | |
| const dict = Object.fromEntries( | |
| projects.map((project) => { | |
| return [ | |
| project, | |
| [ | |
| ...(usersDict[project] || []), | |
| ...(groupsDict[project] || []), | |
| ], | |
| ]; | |
| }), | |
| ); | |
| for (const [project, groups] of Object.entries(groupsDict) { | |
| if (project in usersDict) { | |
| usersDict[project] = usersDict[project].concat(groups) | |
| } else { | |
| usersDict[project] = groups | |
| } | |
| } |
and then return the usersDict instead? That'll save us a lot of iteration and feels more readable to me 🤷🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Implementation of the logic for fetching project owners.
Based on pattern documented in https://docs.getunleash.io/contributing/ADRs/back-end/write-model-vs-read-models
Next up
Internal ticket https://linear.app/unleash/issue/1-2318/get-project-owner-users-and-groups-from-db