feat: enable project creation through new form #6961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
thomasheartman
changed the base branch from
main
to
feat/new-project-creation-form-layout
thomasheartman
changed the title
thomasheartman
commented
Apr 30, 2024
Comment on lines
+75
to
+94
| type FormProps = { | ||
| projectId: string; | ||
| projectName: string; | ||
| projectDesc: string; | ||
| projectStickiness?: string; | ||
| featureLimit?: string; | ||
| featureCount?: number; | ||
| projectMode?: string; | ||
| setProjectStickiness?: React.Dispatch<React.SetStateAction<string>>; | ||
| setProjectId: React.Dispatch<React.SetStateAction<string>>; | ||
| setProjectName: React.Dispatch<React.SetStateAction<string>>; | ||
| setProjectDesc: React.Dispatch<React.SetStateAction<string>>; | ||
| setFeatureLimit?: React.Dispatch<React.SetStateAction<string>>; | ||
| setProjectMode?: React.Dispatch<React.SetStateAction<ProjectMode>>; | ||
| handleSubmit: (e: any) => void; | ||
| errors: { [key: string]: string }; | ||
| mode: 'Create' | 'Edit'; | ||
| clearErrors: () => void; | ||
| validateProjectId: () => void; | ||
| }; |
There was a problem hiding this comment.
These are all the props from the old form. I've put them here as a template. We'll use the ones we need and remove the ones we don't as we go.
thomasheartman
commented
Apr 30, 2024
There was a problem hiding this comment.
Just shove in all the props that we send to the existing form for now, so that we have all the stuff we need.
Tymek
approved these changes
Apr 30, 2024
We're not building this now after all
Because their styles don't get propagated to the top-level component, but instead to the wrapped input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows very simple project creation. You can add a name and description. The ID is generated for you at the moment (we'll fix this later). Nothing else works, but the project is created successfully.