-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Restore AI Siege messages #688
Added Restore AI Siege messages #688
Conversation
tested on SHC extreme and works as intended. I do understand why it was scrapped, however .. so i suggest maybe adding a condition to the triggering of the message otherwise you will hear it ...aloot |
Makes sense. We could make it army size difference for sure, and maybe add a random chance for it like 50%. |
I'd like to have different options here.
|
<3 |
like a greased Jesus =) |
seems like requesting the ai to attack someone continuously triggers the siege message (testing on shc-e with the opponent needs to be weaker option) i was assigning lionheart to attack someone on the other end of the map ..which could play into the issue as he accepted the tast but didnt send out troops. on top of that sometimes the ai send the message without being the "lesser lord" but I suppose the attackedAiStrength is calculated on different values so i pressume its related to that which isnt inherritly bad |
Question: Do I understand it correctly, that the change only reads some random number (and does not generate a new one? Otherwise, different settings lead to desyncs, which is unnecessary...) |
Correct, only reading. Shouldnt cause a desync imo as it only plays a video and does not affect gameplay whatsoever. But havent tested it in multiplayer. |
Test it with 1.41 SHC
|
So what is the current problem with this? |
* Revert "Merge pull request #634 from LordHansCapon/feature/fix_assassin" This reverts commit 21f203d, reversing changes made to b686f90. * Revert "Merge pull request #658 from patel-nikhil/ghost-eng" This reverts commit b686f90, reversing changes made to 0386db7. * Revert "Merge pull request #688 from LordHansCapon/feature/add_restore_ai_siege_message" This reverts commit 0386db7, reversing changes made to d4fa4a1. * Revert "Merge pull request #746 from patel-nikhil/numpad" This reverts commit 6c61300, reversing changes made to 74c4bbe.
AIs have recorded Siege messages which they send to their allies when they are about to attack an enemy. This feature was cut from the game, but the assets remained.
This option restores this feature.
#122
Test build:
https://we.tl/t-NHQSEIVTPa