Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Restore AI Siege messages #688

Conversation

LordHansCapon
Copy link
Contributor

@LordHansCapon LordHansCapon commented Nov 8, 2020

AIs have recorded Siege messages which they send to their allies when they are about to attack an enemy. This feature was cut from the game, but the assets remained.

This option restores this feature.

image

grafik

#122

Test build:
https://we.tl/t-NHQSEIVTPa

@Monsterfisch
Copy link

tested on SHC extreme and works as intended.

I do understand why it was scrapped, however .. so i suggest maybe adding a condition to the triggering of the message otherwise you will hear it ...aloot
one idea would be to start sending these messages after a certain amount of attacks so the army sizes have grown are big enough that the attacks don't happen every half a minute.
Another way would be to limit it to every other attack or make it depend on a difference between attacking army and defender so if the enemy on paper has fewer troops available than the attacker (making the attacker confident) he messages the player/his allies to join in on the siege.

@LordHansCapon
Copy link
Contributor Author

tested on SHC extreme and works as intended.

I do understand why it was scrapped, however .. so i suggest maybe adding a condition to the triggering of the message otherwise you will hear it ...aloot
one idea would be to start sending these messages after a certain amount of attacks so the army sizes have grown are big enough that the attacks don't happen every half a minute.
Another way would be to limit it to every other attack or make it depend on a difference between attacking army and defender so if the enemy on paper has fewer troops available than the attacker (making the attacker confident) he messages the player/his allies to join in on the siege.

Makes sense. We could make it army size difference for sure, and maybe add a random chance for it like 50%.

@ByBurton
Copy link
Collaborator

ByBurton commented Nov 9, 2020

I'd like to have different options here.
-Always active (my take)

  • Always active when weaker, 30% active when stronger (Monsterfish's take)
  • inactive
  • 50% every time
  • ...

@ByBurton
Copy link
Collaborator

ByBurton commented Nov 9, 2020

<3

@Monsterfisch
Copy link

like a greased Jesus =)

@Monsterfisch
Copy link

Monsterfisch commented Nov 9, 2020

seems like requesting the ai to attack someone continuously triggers the siege message (testing on shc-e with the opponent needs to be weaker option) i was assigning lionheart to attack someone on the other end of the map ..which could play into the issue as he accepted the tast but didnt send out troops.

on top of that sometimes the ai send the message without being the "lesser lord" but I suppose the attackedAiStrength is calculated on different values so i pressume its related to that which isnt inherritly bad

@J-T-de
Copy link
Contributor

J-T-de commented Nov 21, 2020

Question: Do I understand it correctly, that the change only reads some random number (and does not generate a new one? Otherwise, different settings lead to desyncs, which is unnecessary...)

@LordHansCapon
Copy link
Contributor Author

Question: Do I understand it correctly, that the change only reads some random number (and does not generate a new one? Otherwise, different settings lead to desyncs, which is unnecessary...)

Correct, only reading. Shouldnt cause a desync imo as it only plays a video and does not affect gameplay whatsoever. But havent tested it in multiplayer.

@Xander10alpha
Copy link

Test it with 1.41 SHC

  1. AI send Siege Message to the Player
  2. in Spectatmode on spectator Maps there send Siege Message to the AI, that i can see

@ByBurton
Copy link
Collaborator

So what is the current problem with this?
Is it the continuous sending if you ask an ally to attack?
If so can this not be fixed?

@Krarilotus Krarilotus added the awaiting premature merge for dev build label Aug 3, 2021
@Krarilotus Krarilotus changed the base branch from master to development August 4, 2021 20:23
@gynt gynt merged commit 0386db7 into UnofficialCrusaderPatch:development Aug 4, 2021
Krarilotus added a commit to Krarilotus/UnofficialCrusaderPatch that referenced this pull request Dec 5, 2021
…apon/feature/add_restore_ai_siege_message"

This reverts commit 0386db7, reversing
changes made to d4fa4a1.
Krarilotus added a commit that referenced this pull request Dec 5, 2021
* Revert "Merge pull request #634 from LordHansCapon/feature/fix_assassin"

This reverts commit 21f203d, reversing
changes made to b686f90.

* Revert "Merge pull request #658 from patel-nikhil/ghost-eng"

This reverts commit b686f90, reversing
changes made to 0386db7.

* Revert "Merge pull request #688 from LordHansCapon/feature/add_restore_ai_siege_message"

This reverts commit 0386db7, reversing
changes made to d4fa4a1.

* Revert "Merge pull request #746 from patel-nikhil/numpad"

This reverts commit 6c61300, reversing
changes made to 74c4bbe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting premature merge for dev build Needs comment by author Needs comment by author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants