Allow changing gamespeed with non-numpad keys

[patel-nikhil]

Allow changing gamespeed with non-numpad +/- keys

[Krarilotus]

Please provide more in deph description which keys will be used instead, also needs a description update of the feature in the patcher itself

[patel-nikhil]

Agree, I can update the UCP description text.

As for which keys: it is the + and - keys that are not on the numpad (without shift modifier fyi).

I feel it is best to describe it as the non-numpad +/- keys, it is the most accurate way to describe it and is the equivalent of how the current behaviour is best described as using the numpad +/- keys.

I am open to suggestion, so let’s confirm this before we update the commit.

[GRhin]

The mapping of non numpad + and - keys might be different for different keyboard languages.
Are you using key combinations? For example on a us keyboard the + is achieved by shift =, or is it the = key without shift?

[LeSpec]

Maybe the event keycode can clarify any confusions. From my understanding: + (=171) - (=173)
https://keycode.info/

[Krarilotus]

my own plus would be 187, minus would be 189. hm interesting

Could we have like keys that have some easy to find position? Like say ß and ´ which are on a german keyboard the ones right of the 0. it would be the ´219 and 221
But i am happy either way to get any keys for this, it should tho be a bit intuitive i would say.
So which keys are actually the ones currently mapped? Because i am not sure how i find that out...

[GRhin]

Would be good to have this tested by as many different keyboard languages as possible. German, english us, english uk, russian, chinese, etc.

…

On Thu, 25 Feb. 2021, 11:41 pm Krarilotus, ***@***.***> wrote: my own plus would be 187, minus would be 189. hm interesting — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALGGWTREVPWCZQBN67J667LTAZAQXANCNFSM4WFRTRFQ> .

[LeSpec]

I can't figure out what the code does, but to your question, it compares esi with 187 and 189.