Refactor UCP website to load text from json #698
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Explain to me I clicked on the link... and I saw there information about UCP 2.14. Is it an old version or is it already information about a new version of UCP ? |
|
This pr is for updating the website, not an update to the ucp. |
patel-nikhil
force-pushed
the
gh-pages
branch
from
d285cfe
to
2fce2b8
Compare
Krarilotus
approved these changes
Nov 28, 2020
|
Good to hear! |
|
yeah but so far it looked good. Ofc stuff is still missing, but what was there looked good. No complaints 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the website to load strings from a json file using javascript.
Preview available at: https://patel-nikhil.github.io/UnofficialCrusaderPatch/index.html