-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add _clean_ocr_languages_arg helper function #2413
Conversation
I know you mentioned this will be used in future PR, but could you give me an idea of where this will be used? Why does this change only impact to the (soon deprecated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for whatever use ocr_languages
still has, this change LGTM. let me know if you can give more context (see earlier question) so I can merge
@shreyanid This is all stemming from users passing in incorrect arguments to the API. The issue that was opened is about accepting those common mistakes (even though |
ok, just revisited the linked issue. I also am not sure when we plan to officially deprecate it. I suppose handling messy |
This PR is one in a series of PRs for refactoring and fixing the languages parameter so it can address incorrect input by users. #2293
This PR adds _clean_ocr_languages_arg. There are no calls to this function yet, but it will be called in later PRs related to this series.