Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate over fsspec connectors #3066

Merged
merged 20 commits into from
Jun 5, 2024
Merged

Conversation

rbiseck3
Copy link
Contributor

@rbiseck3 rbiseck3 commented May 21, 2024

Description

Move over all fsspec connectors to the new framework

Variety of bug fixes found and fixed in this PR as well:

  • custom json mixin being used for the enhanced dataclass would break if typing was quoted. That was fixed. A check was also added to the enhanced dataclass to prevent InitVar from being used in the root dataclass since this breaks serialization.
  • hashing for partitioner was using the filename of the raw file being partitioned rather than the file name of the file data generated from indexing. This means that mutliple files could result in the same partition hash when recursive flag is passed in. This was updated to use the file data file name instead.

@rbiseck3 rbiseck3 force-pushed the roman/migrate-fsspec-connectors branch from 5d3782b to 7147d4c Compare May 21, 2024 19:09
@rbiseck3 rbiseck3 force-pushed the roman/migrate-fsspec-connectors branch from e7786bc to 660986f Compare June 3, 2024 13:26
@rbiseck3 rbiseck3 force-pushed the roman/migrate-fsspec-connectors branch from b506d68 to a877707 Compare June 4, 2024 15:28
@rbiseck3 rbiseck3 force-pushed the roman/migrate-fsspec-connectors branch from 9203fab to bad381b Compare June 4, 2024 18:41
rbiseck3 and others added 20 commits June 5, 2024 13:56
…3140)

This pull request includes updated ingest test fixtures.
Please review and merge if appropriate.

Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
…3141)

This pull request includes updated ingest test fixtures.
Please review and merge if appropriate.

Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
…3148)

This pull request includes updated ingest test fixtures.
Please review and merge if appropriate.

Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
@rbiseck3 rbiseck3 force-pushed the roman/migrate-fsspec-connectors branch from bad381b to 09cf404 Compare June 5, 2024 17:56
@rbiseck3 rbiseck3 enabled auto-merge June 5, 2024 17:58
@rbiseck3 rbiseck3 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit b777864 Jun 5, 2024
46 checks passed
@rbiseck3 rbiseck3 deleted the roman/migrate-fsspec-connectors branch June 5, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants