Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BT segfault #2509

Closed
ghost opened this issue Mar 16, 2023 · 4 comments
Closed

BT segfault #2509

ghost opened this issue Mar 16, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 16, 2023

(gdb) bt
#0  0x00007f049e2b1100 in FreeNode (node=0xcde7c3e44a57619e) at /bigfiles/contrib/unvanquished/Unvanquished/src/sgame/sg_bot_parse.cpp:1603
#1  0x00007f049e2b0d54 in FreeBehaviorTree (tree=0x7f0499063bd0) at /bigfiles/contrib/unvanquished/Unvanquished/src/sgame/sg_bot_parse.cpp:1626
#2  0x00007f049e2b0e51 in FreeTreeList (list=0x7f049e5b2560 <treeList>) at /bigfiles/contrib/unvanquished/Unvanquished/src/sgame/sg_bot_parse.cpp:1478
#3  0x00007f049e2a1a47 in G_BotCleanup () at /bigfiles/contrib/unvanquished/Unvanquished/src/sgame/sg_bot.cpp:610
#4  0x00007f049e3055ab in G_ShutdownGame () at /bigfiles/contrib/unvanquished/Unvanquished/src/sgame/sg_main.cpp:721

This is fully reproducible, and is caused by a problem in the BT files in this case. Game should still not crash for this.
This crash happens when closing the game, there's another one when the game starts. More details later.

@ghost ghost added A-Bots T-Bug labels Mar 16, 2023
@necessarily-equal
Copy link
Contributor

You probably should include the exact BT used if you still can. I don't think I've seen this bug before

@ghost
Copy link
Author

ghost commented Mar 16, 2023

I have not seen those crashes neither (and I played with BTs for more than few minutes). Same for the segfaults I had yesterday when opening a BT with an error.
It might be a regression, but so far I have no clue on this point.

bt.zip

The BT I had with the crash are in the zip file of this message. While I was editing the BT yesterday, I noticed crashes at start of game, but I suspect this is a different problem than the one I mentioned above.

@ghost
Copy link
Author

ghost commented Mar 27, 2023

Warn: Invalid token on line 38 found: changeGoal 
Warn: Failed to parse child node of condition on line 36 
Warn: Could not load behavior default_aliens on line 7 
Warn: Failed to parse child node of condition on line 5 
Warn: Problem when loading behavior tree default, trying default 
Warn: Crashed with signal 11: Segmentation fault 
Waiting for the VM thread... 
----- Server Shutdown ----- 

with a slightly different bt (ok, I probably did something wrong, but should not crash). Quick guess: might be related to trying default... while ti's already default.

Edit: Well... I simply forgot "action"... and even parens. In any case, the segfault there is a regression, pretty sure I've been forgetting those in the past without a crash

@ghost ghost added this to the Beta 55 (v0.55.0) milestone Apr 7, 2023
@slipher
Copy link
Contributor

slipher commented Apr 7, 2023

Fixed in #2575.

@slipher slipher closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants