Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential loss of information from DirToByte()/ByteToDir() usage #2912

Open
VReaperV opened this issue Jan 26, 2024 · 0 comments
Open

Potential loss of information from DirToByte()/ByteToDir() usage #2912

VReaperV opened this issue Jan 26, 2024 · 0 comments

Comments

@VReaperV
Copy link
Contributor

Currently, there's a few places in the game where DirToByte() and ByteToDir() are used to change a vec3_t into an int, and then back. This in a lot of cases results in incorrect data since you can't really put 12 bytes of arbitrary data into 4 bytes. It seems to only be used for some visual effects, like the shotgun spread and acid tubes effects, but it can be misleading nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant