New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback on 982b53b. #30
Comments
This is the directory it is launched from. I will prepopulate it in the install box.
I haven't seen this in my tests. Could you explain how to reproduce this further, perhaps in a separate issue?
You cannot change the install location mid download. The prompting to move the stuff for them seems like something that I wouldn't target for the initial alpha release.
There is feedback (a very generic error message), but it could be better. I will fix this.
I get an admin prompt on windows to run the app. I haven't tried writing to a system location (ie, Program Files). I will fix it if it errors out.
Maybe once we're stable. During alpha, I think it is a bad idea for users to not be clear where the game is installed.
Yep, TODO
TODO. I wasn't targeting it for the initial release. I wanted to get the download and updater part down first.
Good idea.
While the updater is still in development, I think seeing a download history is good so the user can help me debug issues. In the future, I think this is a good idea. The top area will instead be for news and such.
The updater does this if you press updater. I could add a menu option for this, but it would basically do the same thing as updating.
Fairly simple, but I wanted to keep the options minimal. If you want to rate limit, pause it and start it again later. If it becomes a heavily requested feature, I can add it however.
TODO, definitely not for this release, but will be there in future releases.
Yes, but not until its a little further along.
Yeah. Problem is on Windows, you cannot overwrite a running application, so I think the best solution would be an updater updater... |
No, installations shouldn't go to where you download files to, they should go to the locations that are standardized for user-privilege installations, i.e. to
I will when I get around to that.
The generic error message doesn't catch an existing non-writable folder under linux. Try with
There are two types of verification for torrents. One is fast and probably looks at file modification timers to not re-checksum the entire download again (I don't know the exact method though, timers is juts a guess). That's the one you correctly use whenever the launcher checks for updates. The other is a complete re-checksuming of the entire download to look for broken files, which can take a long time. I'm not sure when this is necessary (i.e. what errors aren't catched by the fast approach) but every torrent client offers this option and I wouldn't be surprised if existing launchers offer this too for similiar reasons. I know that steam has this option.
Can you maybe fork and disown a process that does this, then starts the new binary? I think there must be some way to achieve that "your application has updated and needs to be restarted now" effect. I mean, if not on Windows where else?
I'm fine with both a pause button and a rate limit. I'm pretty sure most proprietary launchers don't even bother to implement either. If a user is on a really low bandwith link, a pause button doesn't do anything for them as they just want to be able to watch videos/play games/etc. during their mutliple hour download. It's merely the "Can you stop downloading, I'm ingame for another ten minutes!" situation where a pause button makes any sense but even then a rate limit does the trick as well. Both are kind of optional in my opionion but the limit is certainly more powerful. |
Unticked
as it isn't actually implemented. Note that changing the download location doesn't even trigger a re-download on next launch, you would need to hit the verify button. (Quick verification on startup by timestamp or so doesn't seem to be implemented yet?) |
It doesn't even continue an unfinished download anymore. It just tells you the game was up to date… |
I don't recall ever seeing this in any other installer, so I think we are doing well enough by having a "Pause" button. This should be sufficient if you are in a video call or something and need to stop the updater to free up bandwidth. Other remaining items have been moved to dedicated issues. |
~
(check the Posix/XDG/etc. standards, maybe~/.local/share
is the correct location but I'm not sure), for Windows use whatever steam uses for downloaded games, etc. That default needs to be displayed in the first-start install-selection textbox.--debug
switch). We can use the space you currently print the log to later for news and changelogs.The text was updated successfully, but these errors were encountered: