Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows 10] Updater loading forever #36

Closed
GamesOpenSource opened this issue Aug 14, 2019 · 6 comments
Closed

[Windows 10] Updater loading forever #36

GamesOpenSource opened this issue Aug 14, 2019 · 6 comments

Comments

@GamesOpenSource
Copy link

GamesOpenSource commented Aug 14, 2019

The (assumed news) widget in the center never loads.

image

Also, the area at the bottom contains no content - only if you press the download icon (which is in the screenshot replaced by the play icon) then that area contains information.

Not sure whether these are technological or usability issues.

EDIT: here's a video https://www.youtube.com/watch?v=_0HEZzBGZbg

@slipher
Copy link
Contributor

slipher commented Aug 14, 2019

I wonder if the news could be another HTTPS redirect issue?

@illwieckz
Copy link
Member

The http://www.unvanquished.net/?json=get_recent_posts url (used by updater) was kept available with http protocol and www prefix without any redirection on purpose. So unless I missed another url, the problem seems to be elsewhere. I know that after enabled this URL on http, I tested both Linux and Window (running on wine) updater and they both fetched the latest news but failed to fetch the older ones for an unknown reason. I don't have windows machine right to me at this time to do more tests.

Note that the json file references images with https protocol and we know the windows build of the updater does not support https yet. I don't know how would behaves the updater in this case: displays nothing or display the blog post without image, it would be the later since the blog post is successfully fetched in any way.

@GamesOpenSource
Copy link
Author

GamesOpenSource commented Aug 15, 2019

@illwieckz
Copy link
Member

illwieckz commented Aug 16, 2019

This is expected because that's what is written in config files on purpose, we don't have to care about redirects on anything else than http://www because this is the url hardcoded in the current updater (until any update that would change it) and because the updater does not handle redirects. Others scenarios are not useful to this thread.

@illwieckz
Copy link
Member

illwieckz commented Aug 16, 2019

OK, I did a lot of dark margic with nginx, rewriting the wordpress' json on the fly when fetched the way the updater fetches it, i.e. replacing the images url with http://www when json is fetched with http://www, and enabling images to be fetched the http with www way.

This seems to work. The older news (when clicking "right arrow") is still not displayed and I guess it's that because the json sets null for the thumbnail, and it looks like the updater does not display the blog post at all if the thumbnail is missing. There is other ways to get thumbnails from json, so before trying to fix wordpress database, I keep the issue so we can investigate. In any way it does not prevent to display the current blog post.

@illwieckz
Copy link
Member

usability issue is tracked in #42, the technical one seems to be fixed as seen on discord today (screenshot by @GamesOpenSource) :

updater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants