Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater does not support https on Windows #37

Closed
illwieckz opened this issue Aug 16, 2019 · 6 comments
Closed

updater does not support https on Windows #37

illwieckz opened this issue Aug 16, 2019 · 6 comments

Comments

@illwieckz
Copy link
Member

updater does not support https on Windows

@illwieckz
Copy link
Member Author

Can we assume next build will support it and close this?

@slipher
Copy link
Contributor

slipher commented Jan 4, 2021

Can we assume next build will support it and close this?

No. I have verified that aria2's https is working, but I have no idea if it is possible with Qt requests. Note that Linux also has issues - #64.

@illwieckz
Copy link
Member Author

illwieckz commented Jan 5, 2021

So if I assume correctly, once #64 is fixed, next Linux/Windows/macOS will be able to:

  1. download anything with https (updater updates, torrent file, version file) with aria2
  2. may not be able to download https thing (blog post, images) with qt

Se we can already replace all non-blog urls with https ones.

@slipher
Copy link
Contributor

slipher commented Jan 5, 2021

The versions.json request is using the Qt network code

@slipher
Copy link
Contributor

slipher commented Jan 7, 2021

I tested https with the Qt network requests and it is actually working. Either it was fixed by upgrading to Qt 5.14, or the original report was mistaken (possibly confusing with the redirect issue? I haven't tested redirects.)

@slipher slipher closed this as completed Jan 7, 2021
@slipher
Copy link
Contributor

slipher commented Jan 17, 2021

The flag -schannel must be passed to the configure script for Qt to support HTTPS. The old Docker build did not have this option, so probably the reason it started working was that MXE configured it with -schannel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants