Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drive short name needs restricting to 50 or fewer characters. #56

Open
akea013 opened this issue Oct 6, 2020 · 8 comments
Open

drive short name needs restricting to 50 or fewer characters. #56

akea013 opened this issue Oct 6, 2020 · 8 comments
Assignees
Labels

Comments

@akea013
Copy link
Contributor

akea013 commented Oct 6, 2020

please restrict length of name users can supply for drive short name to no more than 50 characters.
Supplying shortname NZ-perioperative-department-responses-to-Covid-19 which gets prefixed by resmed202000038-
gives error

Name is too long. Please reduce to a maximun of 60 characters. (Workflow:UoA-Unifiles-Validator / Scripting (item4)#7)

@Hganavak
Copy link
Contributor

Hganavak commented Oct 6, 2020

What drive names are you referring to? Do you just mean the storage folder name in the Request Research Storage form?

Screen Shot 2020-10-07 at 9 25 09 AM

@akea013
Copy link
Contributor Author

akea013 commented Oct 6, 2020 via email

@akea013
Copy link
Contributor Author

akea013 commented Oct 6, 2020 via email

@Hganavak
Copy link
Contributor

Hganavak commented Oct 6, 2020

Just to confirm. The only update you would like us to make on our end, is to make the input form (in the screenshot above):

Please provide a descriptive title for your storage folder (e.g. GDC-data)?

To allow a max of 50 chars?

If so we can add that on to the beginning of our next sprint (so it'll be deployed on the 19/20th). Does that work for you?

@akea013
Copy link
Contributor Author

akea013 commented Oct 6, 2020 via email

@Hganavak
Copy link
Contributor

Hganavak commented Oct 6, 2020

"Please provide a unique descriptive title for your storage folder (e.g. GDC-data-<unique_string_here>)"

We can't reasonably expect users to generate a unique string here just for our internal purposes, that would be super duper weird interface.

Could I suggest updating your Dropbox creation API/tool to just append 5 random alphanumeric characters to the folder name? We could then limit the short-name to 45 characters on our end.

Alternatively, we could do this for you, but we currently don't have any way of knowing whether the user is requesting only a Dropbox folder, or Dropbox + Research Storage, so we would end up also appending the 5 random characters to Research Storage short names (which as you mentioned don't need this).

and notice that I've removed the question mark as this statement is not a question but a request.

I noticed this too, we will fix that ASAP?

@akea013
Copy link
Contributor Author

akea013 commented Oct 6, 2020 via email

@akea013
Copy link
Contributor Author

akea013 commented Oct 7, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants