Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set device_id for Kokkos #184

Merged
merged 6 commits into from
Jan 26, 2024
Merged

set device_id for Kokkos #184

merged 6 commits into from
Jan 26, 2024

Conversation

milthorpe
Copy link

Previously, the Kokkos implementation ignores the command line parameter --device and always runs using the default device. This change initializes Kokkos with the specified device.

illuhad and others added 6 commits December 4, 2023 11:13
Revert "Remove AdaptiveCpp workaround in dpl_shim.h to allow for automatic prefetch optimization"
Revert "Rename Julia package to `BabelStream.jl` and add compats"
Previously, the Kokkos implementation ignores the command line parameter `--device` and always runs using the default device. This change initializes Kokkos with the specified device.
@milthorpe milthorpe changed the title correctly set device_id for Kokkos set device_id for Kokkos Jan 26, 2024
@tomdeakin
Copy link
Contributor

Looks good, just re-running the CI.

@tomdeakin tomdeakin changed the base branch from main to develop January 26, 2024 11:40
@tomdeakin
Copy link
Contributor

CI is failing only after the cpp test passes, so this looks good to merge. Thanks for the contribution!

@tomdeakin tomdeakin merged commit c3bc027 into UoB-HPC:develop Jan 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants