Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies version #73

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

vietnguyengit
Copy link
Contributor

Unpinned dependency versions cause conflicts, and dependencies should not be left unpinned in the requirements.txt file either. Feel free to change the versions as you prefer, but please avoid leaving them unpinned.

You can consider using poetry for better dependency management. It provides a lock file and stores the version of every single dependency, including dependencies of other dependencies. Poetry's dependency resolver is better than pip's as well. You can avoid issue like this: #60

I can submit a PR to switch to using poetry; however, since it's your app, I won't touch the architecture unless requested. For now, this PR aims to fix immediate problem.

I also modified the .gitignore because I and probably many others using JetBrains IDEs.

Error logs using the default requirements.txt

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gpt-computer-assistant 0.0.0 requires langchain==0.2.3, but you have langchain 0.1.20 which is incompatible.
gpt-computer-assistant 0.0.0 requires langchain-community==0.2.3, but you have langchain-community 0.0.38 which is incompatible.
gpt-computer-assistant 0.0.0 requires langchain-experimental==0.0.60, but you have langchain-experimental 0.0.58 which is incompatible.
gpt-computer-assistant 0.0.0 requires langchain-openai<0.2.0,>=0.1.8, but you have langchain-openai 0.1.7 which is incompatible.
gpt-computer-assistant 0.0.0 requires langgraph<0.0.65,>=0.0.64, but you have langgraph 0.0.51 which is incompatible.

Cheers

@onuratakan onuratakan self-assigned this Jun 7, 2024
@onuratakan
Copy link
Member

Hi, you are so right and thank you so much. If you are available can i want your poetry experience.

@vietnguyengit
Copy link
Contributor Author

Hi, you are so right and thank you so much. If you are available can i want your poetry experience.

Thank you for your amazing work into this project @onuratakan

I'll submit the poetry PR then. I've created an issue here for traceability: #75

If you could assign me to it, it would help avoid redundant efforts.

Meanwhile, if you could review this PR for an immediate fix because it doesn't work out-of-the-box.

Thank you.

@onuratakan onuratakan merged commit db02b34 into Upsonic:master Jun 7, 2024
@vietnguyengit vietnguyengit deleted the pin-dependencies-versions branch June 12, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants