remove implicit addition of "TT_" prefix to token-type macros, because i... #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it's confusing to require them in one place but not others
|
This change breaks the examples. There are currently no tests for them (not your problem), but they should at least build. You can try building them with |
|
Cool, I'll fix them soon. As an aside, it would be nice if the Dev Guide had a "what to run after you make a change" section, including things like building the examples and running the benchmarks. (I had to dig around a bit to figure out the latter.) |
|
I dug around quite a bit more and it seems the implicitness of the TT_ prefix is more deeply embedded than I anticipated. I hereby revoke this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...t's confusing to require them in one place but not others.
Just changing these two lines did not break any of the tests that weren't already broken on my (ia32) machine, and there are no other instances of "\WTT_\W" in the source, so I'm hopeful this is sufficient.