Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUANTRampAPI2.py v quant_api.py #268

Closed
Sparrow0hawk opened this issue Mar 11, 2021 · 2 comments
Closed

QUANTRampAPI2.py v quant_api.py #268

Sparrow0hawk opened this issue Mar 11, 2021 · 2 comments

Comments

@Sparrow0hawk
Copy link
Contributor

I'm nit picking through things on documentation and have noticed we have both QUANTRampAPI2.py and quant_api.py.

They both lack tests but also seem broadly to do similar things with quant_api.py simply being a more standard python module.

@nickmalleson are we able to tidy this up and remove QUANTRampAPI2.py from microsim module?

@ciupava
Copy link
Contributor

ciupava commented Mar 11, 2021

I don't think that QuantRampAPI2 is actually used.

nickmalleson pushed a commit that referenced this issue Mar 12, 2021
@nickmalleson
Copy link
Collaborator

Indeed, QuantRampAPI2 is a hangover from some old code that Natalie was writing. I have deleted it as part of issue #267 (in commit d769ee1) . We should write tests for quant_api.py, this is the subject of #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants