Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add traveltimes to vignette #80

Merged
merged 5 commits into from
Mar 17, 2021

Conversation

AlexandraKapp
Copy link
Contributor

extension of the vignette for the gtfs_traveltimes function.
I kept it quite basic. Any additions or futher explanations that should be included?

@mpadge
Copy link
Member

mpadge commented Mar 2, 2021

Thanks @AlexandraKapp, but please see #55 first - I think this would be much better in it's own separate vignette. Could you please accordingly copy your code across to a new vignette file, and we'll start from there? Thanks!

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #80 (a3c8d47) into main (b74a2b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          19       19           
  Lines        1826     1826           
=======================================
  Hits         1604     1604           
  Misses        222      222           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74a2b7...5c29829. Read the comment docs.

@mpadge
Copy link
Member

mpadge commented Mar 12, 2021

Thanks for putting your name on it. Current version now fails because of new start_time_limits parameter which expects two values, and fails if there is only one, as in current code. Once you've updated that, I'll happily merge.

@AlexandraKapp
Copy link
Contributor Author

now it should work :) feel free to edit or add content

@mpadge mpadge merged commit d4a9237 into UrbanAnalyst:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants