Do not try to call onRequest on non-object providers

Signed-off-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
Urigo · Nov 7, 2018 · c70b9f9 · c70b9f9
1 parent ef146af
commit c70b9f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/core/src/di/injector.ts b/packages/core/src/di/injector.ts
@@ -110,7 +110,12 @@ export class Injector {
 
     const instance = this.getByProvider(provider);
 
-    if (instance && 'onRequest' in instance) {
+    if (
+      instance &&
+      typeof instance !== 'string' &&
+      typeof instance !== 'number' &&
+      'onRequest' in instance
+      ) {
       return instance.onRequest(request, context, appModule);
     }
   }

diff --git a/packages/core/src/graphql-module.ts b/packages/core/src/graphql-module.ts
@@ -69,7 +69,7 @@ export interface GraphQLModuleOptions<Config, Request, Context> {
  * the module's name.
  * You can use this later with `@Inject` in your `Provider`s.
  *
- * @param name - the name of the module
+ * @param module
  * @constructor
  */
 export const ModuleConfig = (module: string | GraphQLModule) =>