Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package json exports to include type definitions #2324

Merged
merged 2 commits into from Mar 16, 2023

Conversation

patrickjm
Copy link
Contributor

Related to #2323

Description

Typescript 5.0 is in beta, and it adds a couple new compiler options.

If you want to use the new moduleResolution mode "bundler" or compiler option "resolvePackageJsonExports", Typescript will ignore the top-level "types" field in your package.json and only look for types inside package.json "exports".

See: microsoft/TypeScript#52363

That means, types need to be directly pointed at in package.json exports.

Partially addresses #2323

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

🦋 Changeset detected

Latest commit: 3a341c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-modules Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Collaborator

Thanks @patrickjm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants